Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Reparent file picker and viewer in fullscreen mode #6885

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #6879

By default the file picker and the viewer are siblings of the fullscreen
element, so they are not visible when in fullscreen mode. It is not
possible to specify the parent nor to know when the file picker or the
viewer were actually opened, so for the time being they are reparented
if needed shortly after calling them.

This is just a temporary hack until it is possible to specify the parent
element, but that would require changes in the Vue library, the viewer
and the server dialogs, so this horrible code will have to do for now.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@nickvergessen nickvergessen merged commit 13881b8 into stable23 Feb 8, 2022
@nickvergessen nickvergessen deleted the backport/6879/stable23 branch February 8, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants